Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): app layout and event handler #5279

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

amanape
Copy link
Member

@amanape amanape commented Nov 26, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

  • Move posthog.capture("user_activated"); capture logic to user prefs context
  • Move _oh.app.tsx to _oh.app/route.tsx
  • Contain all relevant components within the new _oh.app directory
  • Refactor chat-interface.tsx
  • Refactor event-handler.tsx into hooks (would like @tofarr's opinions here)

Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:c370bcf-nikolaik   --name openhands-app-c370bcf   docker.all-hands.dev/all-hands-ai/openhands:c370bcf

@amanape amanape marked this pull request as ready for review November 26, 2024 16:38
@amanape amanape requested a review from tofarr November 26, 2024 16:39
@amanape amanape changed the title refactorf(frontend): app layout and event handler refactor(frontend): app layout and event handler Nov 26, 2024
@amanape amanape self-assigned this Nov 26, 2024
Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@amanape amanape merged commit f4ef6ab into main Nov 26, 2024
14 checks passed
@amanape amanape deleted the ALL-779/refactor-app-layout branch November 26, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants